github-actions[bot] closed pull request #14523: Support bounds evaluation for
temporal data types
URL: https://github.com/apache/datafusion/pull/14523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2978700370
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
berkaysynnada commented on code in PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#discussion_r2049071746
##
datafusion/expr-common/src/interval_arithmetic.rs:
##
@@ -963,6 +961,23 @@ pub fn apply_operator(op: &Operator, lhs: &Interval, rhs:
&Interval) -> Result
berkaysynnada commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2812071975
Thank you @ch-sc. I will review it today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ch-sc commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2797103457
Sorry @berkaysynnada, I got side-tracked from this yesterday. The test is
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
berkaysynnada commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2796267763
Hi @ch-sc. Reviewing while tests are failing is not very efficient. Are you
dealing with them?
--
This is an automated message from the Apache Git Service.
To respond to the
berkaysynnada commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2792466034
> Hi @berkaysynnada, can you take another look to move this forward? :)
I will do but some tests are failing. I'll have some time probably in the
evening or tomorrow morn
ch-sc commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2789351136
Hi @berkaysynnada, can you take another look to move this forward? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
ch-sc commented on code in PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#discussion_r2014120634
##
datafusion/expr-common/src/interval_arithmetic.rs:
##
@@ -902,6 +960,15 @@ pub fn apply_operator(op: &Operator, lhs: &Interval, rhs:
&Interval) -> Result lhs.sub
ch-sc commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2728490058
Hi @berkaysynnada, I should be able to spend some time on this at the end of
this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
berkaysynnada commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2727459728
Hi @ch-sc. Do you plan to complete the work here? (as it's so almost)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ch-sc commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2682042295
@berkaysynnada thank you for your review 🙂
> Rather than introducing new supports_() API's, should we force the users
to infer the support by the evaluate API?
I agree, s
ch-sc commented on code in PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#discussion_r1968018999
##
datafusion/physical-expr/src/expressions/in_list.rs:
##
@@ -398,6 +399,51 @@ impl PhysicalExpr for InListExpr {
self.static_filter.clone(),
ch-sc commented on code in PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#discussion_r1967699042
##
datafusion/expr/src/udf.rs:
##
@@ -717,9 +722,18 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
///
/// If the function is `ABS(a)`, and the input in
ch-sc commented on code in PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#discussion_r1968018999
##
datafusion/physical-expr/src/expressions/in_list.rs:
##
@@ -398,6 +399,51 @@ impl PhysicalExpr for InListExpr {
self.static_filter.clone(),
ch-sc commented on code in PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#discussion_r1967699042
##
datafusion/expr/src/udf.rs:
##
@@ -717,9 +722,18 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
///
/// If the function is `ABS(a)`, and the input in
ch-sc commented on code in PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#discussion_r1967570230
##
datafusion/common/src/scalar/mod.rs:
##
@@ -1583,6 +1583,17 @@ impl ScalarValue {
}
}
+/// Returns negation for a boolean scalar value
+pu
berkaysynnada commented on code in PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#discussion_r1966851842
##
datafusion/common/src/scalar/mod.rs:
##
@@ -1583,6 +1583,17 @@ impl ScalarValue {
}
}
+/// Returns negation for a boolean scalar value
ch-sc commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2665828516
Looks like I confused the meaning of nulls in intervals. I switched to the
union logic @berkaysynnada suggested.
--
This is an automated message from the Apache Git Service.
To respo
ch-sc commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2660141218
> I took a quick look, and you can use the union logic there
I thought a bit more about the union logic and came up with another
solution.
Sometimes intervals are not ove
ch-sc commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2656384285
> I try to add support for NotEq. If I find a solution, I can fix it within
this PR itself—if that's okay with you.
Sure, feel free to make any adjustment as you see fit.
--
T
ch-sc commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2653779520
@berkaysynnada do you have time to take another look? :)
`NotEq` leads to the removal of the sort operator.
I debugged into this and noticed that the `EnforceSorting` opti
berkaysynnada commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2642846047
> Sometimes the sort operator gets removed as can be seen in the
`repartition_scan.slt` test.
Seems like you're losing the order requirement somehow
--
This is an auto
ch-sc commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2642837400
Thanks @berkaysynnada! Yeah I'd like to get a review.
There is still a bug, though, that I don't understand yet. Sometimes the
sort operator gets removed as can be seen in the `r
berkaysynnada commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2642167448
Thank you @ch-sc for working on this. When you need a review, I can do that
if you ping me.
--
This is an automated message from the Apache Git Service.
To respond to the mes
ch-sc opened a new pull request, #14523:
URL: https://github.com/apache/datafusion/pull/14523
## Which issue does this PR close?
As discussed in [14237](https://github.com/apache/datafusion/issues/14237)
temporal data types should be supported in bounds evaluation.
- Cl
26 matches
Mail list logo
