ch-sc commented on PR #14523: URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2653779520
@berkaysynnada do you have time to take another look? :) `NotEq` leads to the removal of the sort operator. I debugged into this and noticed that the `EnforceSorting` optimiser removes `SortExec`. [enforce_sorting/mod.rs:415][1] However, prior to that the order requirement somehow is lost and I don't understand why that happens. I removed `NotEq` again from the supported binary operators to move this forward. We might want to look into this in a follow-up PR. WDYT? [1]: https://github.com/apache/datafusion/blob/02cc22eebd7e422cbba6788971f2ffae103180e8/datafusion/physical-optimizer/src/enforce_sorting/mod.rs#L415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
