github-actions[bot] closed pull request #1614: Parse Postgres's LOCK TABLE
statement
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#issuecomment-2745969727
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or
alamb commented on PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#issuecomment-2604104920
Marking as draft as I think this PR is no longer waiting on feedback. Please
mark it as ready for review when it is ready for another look
--
This is an automated messag
alamb commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1923330659
##
src/ast/mod.rs:
##
@@ -7278,16 +7279,126 @@ impl fmt::Display for SearchModifier {
}
}
+/// A `LOCK TABLE ..` statement. MySQL and Postgres va
iffyio commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1907585091
##
src/ast/mod.rs:
##
@@ -7278,16 +7279,126 @@ impl fmt::Display for SearchModifier {
}
}
+/// A `LOCK TABLE ..` statement. MySQL and Postgres v
freshtonic commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1903356404
##
src/ast/mod.rs:
##
@@ -7278,16 +7279,126 @@ impl fmt::Display for SearchModifier {
}
}
+/// A `LOCK TABLE ..` statement. MySQL and Postgr
freshtonic commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1903354362
##
src/ast/mod.rs:
##
@@ -7278,16 +7279,126 @@ impl fmt::Display for SearchModifier {
}
}
+/// A `LOCK TABLE ..` statement. MySQL and Postgr
iffyio commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1903247158
##
src/ast/mod.rs:
##
@@ -3341,16 +3341,13 @@ pub enum Statement {
value: Option,
is_eq: bool,
},
-/// ```sql
-/// LOCK T
freshtonic commented on PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#issuecomment-2571280859
@iffyio I've pushed another attempt at this.
Munging the Postgres and MySQL versions together into the same
`Statement::LockTables { .. }` variant was painful du
iffyio commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1896659962
##
src/parser/mod.rs:
##
@@ -9604,7 +9604,13 @@ impl<'a> Parser<'a> {
top = Some(self.parse_top()?);
}
-let projection =
freshtonic commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1895681055
##
src/parser/mod.rs:
##
@@ -9604,7 +9604,13 @@ impl<'a> Parser<'a> {
top = Some(self.parse_top()?);
}
-let projecti
freshtonic commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1895681055
##
src/parser/mod.rs:
##
@@ -9604,7 +9604,13 @@ impl<'a> Parser<'a> {
top = Some(self.parse_top()?);
}
-let projecti
freshtonic commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1894703918
##
src/ast/mod.rs:
##
@@ -3336,6 +3336,27 @@ pub enum Statement {
is_eq: bool,
},
/// ```sql
+/// LOCK [ TABLE ] [ ONLY ] nam
freshtonic commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1894703311
##
src/parser/mod.rs:
##
@@ -9604,7 +9604,13 @@ impl<'a> Parser<'a> {
top = Some(self.parse_top()?);
}
-let projecti
iffyio commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1894627136
##
src/parser/mod.rs:
##
@@ -9604,7 +9604,13 @@ impl<'a> Parser<'a> {
top = Some(self.parse_top()?);
}
-let projection =
freshtonic opened a new pull request, #1614:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1614
See: https://www.postgresql.org/docs/current/sql-lock.html
PG's full syntax for this statement is supported:
```
LOCK [ TABLE ] [ ONLY ] name [ * ] [, ...] [ IN lockm
16 matches
Mail list logo