freshtonic commented on PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#issuecomment-2571280859
@iffyio I've pushed another attempt at this.
Munging the Postgres and MySQL versions together into the same
`Statement::LockTables { .. }` variant was painful due to requiring additional
fields that could be relied upon for a correct `Display` implementation which
would produce a valid statement for both MySQL and Postgres.
In my opinion, introducing a `LockTables` enum (with two variants for
Postgres & MySQL and which is marked `non_exhaustive` in order to support other
variations in the future) is less of a cognitive burden than inlining all
variations as lots of optional fields on the same struct.
That said, it does not appear to be an idiom that us used elsewhere so I
don't have much confidence this PR will be accepted but one can hope :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
