xudong963 merged PR #15258:
URL: https://github.com/apache/datafusion/pull/15258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
blaginin commented on code in PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#discussion_r2010279421
##
datafusion/core/src/datasource/physical_plan/parquet.rs:
##
@@ -608,19 +609,19 @@ mod tests {
.round_trip_to_batches(vec![batch1, batch2])
blaginin commented on code in PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#discussion_r2010285393
##
datafusion/core/src/datasource/physical_plan/parquet.rs:
##
@@ -608,19 +609,19 @@ mod tests {
.round_trip_to_batches(vec![batch1, batch2])
blaginin commented on code in PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#discussion_r2010236013
##
datafusion/core/src/datasource/file_format/csv.rs:
##
@@ -708,13 +717,17 @@ mod tests {
let query_result = ctx.sql(query).await?.collect().await?;
xudong963 commented on code in PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#discussion_r2010229831
##
datafusion/core/src/datasource/file_format/csv.rs:
##
@@ -708,13 +717,17 @@ mod tests {
let query_result = ctx.sql(query).await?.collect().await?;
shruti2522 commented on PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#issuecomment-2745098806
I have migrated all the tests for `datasource` to `insta`, except these two,
I’m still working on these and will open a separate PR for it.
1.
`physical_plan::json::tests::test
blaginin commented on code in PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#discussion_r2001416176
##
datafusion/core/Cargo.toml:
##
@@ -126,6 +126,7 @@ datafusion-physical-plan = { workspace = true }
datafusion-sql = { workspace = true }
flate2 = { version =
alamb commented on PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#issuecomment-2727332208
Thanks @shruti2522 !
It looks like there are some CI failures on this one so marking as draft for
now
--
This is an automated message from the Apache Git Service.
To respond t
shruti2522 opened a new pull request, #15258:
URL: https://github.com/apache/datafusion/pull/15258
## Which issue does this PR close?
- Closes #15246 .
## Rationale for this change
## What changes are included in this PR?
## Are these change
