shruti2522 commented on PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#issuecomment-2745098806
I have migrated all the tests for `datasource` to `insta`, except these two,
I’m still working on these and will open a separate PR for it.
1.
`physical_plan::json::tests::test_json_with_repartitioning::case_1_uncompressed`
: for this one, on using `batches_to_string`, only one case is failing and on
using `batches_to_sort_string` all of them are failing.
```
----
datasource::physical_plan::json::tests::test_json_with_repartitioning::case_1_uncompressed
stdout ----
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: json_with_repartitioning
Source: datafusion/core/src/datasource/physical_plan/json.rs:582
────────────────────────────────────────────────────────────────────────────────
Expression: batches_to_string(&res)
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
0 0 │ +-----+------------------+---------------+------+
1 1 │ | a | b | c | d |
2 2 │ +-----+------------------+---------------+------+
3 │+| 2 | [2.0, , -6.1] | [false, ] | text |
4 │+| | | | |
3 5 │ | 1 | [2.0, 1.3, -6.1] | [false, true] | 4 |
4 6 │ | -10 | [2.0, 1.3, -6.1] | [true, true] | 4 |
5 │-| 2 | [2.0, , -6.1] | [false, ] | text |
6 │-| | | | |
7 7 │ +-----+------------------+---------------+------+
────────────┴───────────────────────────────────────────────────────────────────
```
3. this one is failing because of LF (\n) and CR (\r) diff
```
----
datasource::physical_plan::csv::tests::test_create_external_table_with_terminator_with_newlines_in_values
stdout ----
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: create_external_table_with_terminator_with_newlines_in_values
Source: datafusion/core/src/datasource/physical_plan/csv.rs:591
────────────────────────────────────────────────────────────────────────────────
Expression: batches_to_string(&df)
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
0 0 │ +-------+-----------------------------+␊
1 1 │ | col1 | col2 |␊
2 2 │ +-------+-----------------------------+␊
3 │ -| 1 | hello␊
3 | +| 1 | hello␍
4 4 │ world |␊
5 │-| 2 | something␊
5 │+| 2 | something␍
6 6 │ else |␊
7 │-| 3 | ␊
8 │-many␊
9 │-lines␊
10 │-make␊
11 │-good test␊
7 │+| 3 | ␍
8 │+many␍
9 │+lines␍
10 │+make␍
11 │+good test␍
12 12 │ |␊
13 13 │ | 4 | unquoted |␊
14 14 │ | value | end |␊
15 15 │ +-------+-----------------------------+
────────────┴───────────────────────────────────────────────────────────────────
```
cc @blaginin @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
