alamb commented on PR #15578:
URL: https://github.com/apache/datafusion/pull/15578#issuecomment-2782936412
Thanks @qstommyshu !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
alamb merged PR #15578:
URL: https://github.com/apache/datafusion/pull/15578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
qstommyshu commented on PR #15578:
URL: https://github.com/apache/datafusion/pull/15578#issuecomment-2781841733
Got it, Thanks @alamb for your thoughts.
I will update `roundtrip_statement_with_dialect()`. I will probably go with
the macro approach because the macro approach is essent
alamb commented on PR #15578:
URL: https://github.com/apache/datafusion/pull/15578#issuecomment-2781575831
> Just want to confirm, do I need to migrate the big test case
roundtrip_statement_with_dialect() ?
IN my opinion, it is is note required. If you want to rewrite it I am sure
it
qstommyshu commented on PR #15578:
URL: https://github.com/apache/datafusion/pull/15578#issuecomment-2781439769
> Hi @alamb and @blaginin
>
> I found a way to migrate `roundtrip_statement_with_dialect()` now, just
want to confirm if you like to proceed with it.
>
> What I did b
alamb commented on code in PR #15578:
URL: https://github.com/apache/datafusion/pull/15578#discussion_r2030152111
##
datafusion/sql/tests/cases/diagnostic.rs:
##
@@ -136,7 +137,7 @@ fn test_table_not_found() -> Result<()> {
let query = "SELECT * FROM /*a*/personx/*a*/";
qstommyshu commented on PR #15578:
URL: https://github.com/apache/datafusion/pull/15578#issuecomment-2781397695
Hi @alamb and @blaginin
I found a way to migrate `roundtrip_statement_with_dialect()` now, just want
to confirm if you like to proceed with it. What I did below is to incor
qstommyshu opened a new pull request, #15578:
URL: https://github.com/apache/datafusion/pull/15578
## Which issue does this PR close?
- Related #15484, #15397, #15497, #15499, #15533, #15548 , #15567
- this is a part of #15484 breaking down.
- Checkout things to note of t
qstommyshu commented on PR #15578:
URL: https://github.com/apache/datafusion/pull/15578#issuecomment-2779584934
Also, I found the test cases are a bit here and there, but I think the sql
test suite are too large to restructure now. I'm thinking maybe we can try to
use modules to separate di
qstommyshu commented on PR #15578:
URL: https://github.com/apache/datafusion/pull/15578#issuecomment-2779568810
This is the last PR for #15397
The migration is mostly done. There are just a few really big tests that I
think they would be too big to break down and use inline assertion
10 matches
Mail list logo
