qstommyshu commented on PR #15578: URL: https://github.com/apache/datafusion/pull/15578#issuecomment-2781841733
Got it, Thanks @alamb for your thoughts. I will update `roundtrip_statement_with_dialect()`. I will probably go with the macro approach because the macro approach is essentially the same as the original test, so I can almost follow the original `TestStatementWithDialect` structure. Plus, I don't need to create a new struct and impl traits. I can foresee the code changes will be large, so I will leave it to the next PR (part 7, should be the *real* last part). Please merge this PR if you think the change is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
