qstommyshu commented on code in PR #15984:
URL: https://github.com/apache/datafusion/pull/15984#discussion_r2081559659
##
datafusion/optimizer/src/analyzer/type_coercion.rs:
##
@@ -1569,37 +1810,60 @@ mod test {
let empty = empty_with_type(DataType::Boolean);
l
alamb commented on PR #15984:
URL: https://github.com/apache/datafusion/pull/15984#issuecomment-2867208259
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
blaginin commented on code in PR #15984:
URL: https://github.com/apache/datafusion/pull/15984#discussion_r208156
##
datafusion/optimizer/src/analyzer/type_coercion.rs:
##
@@ -1569,37 +1810,60 @@ mod test {
let empty = empty_with_type(DataType::Boolean);
let
blaginin merged PR #15984:
URL: https://github.com/apache/datafusion/pull/15984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
qstommyshu commented on code in PR #15984:
URL: https://github.com/apache/datafusion/pull/15984#discussion_r2081563280
##
datafusion/optimizer/src/test/mod.rs:
##
@@ -99,29 +99,20 @@ pub fn get_tpch_table_schema(table: &str) -> Schema {
}
}
Review Comment:
Looks like
Copilot commented on code in PR #15984:
URL: https://github.com/apache/datafusion/pull/15984#discussion_r2080588006
##
datafusion/optimizer/src/test/mod.rs:
##
@@ -99,29 +99,20 @@ pub fn get_tpch_table_schema(table: &str) -> Schema {
}
}
Review Comment:
[nitpick] Con
blaginin commented on code in PR #15984:
URL: https://github.com/apache/datafusion/pull/15984#discussion_r2080589228
##
datafusion/optimizer/src/analyzer/type_coercion.rs:
##
@@ -1569,37 +1810,60 @@ mod test {
let empty = empty_with_type(DataType::Boolean);
let
qstommyshu commented on PR #15984:
URL: https://github.com/apache/datafusion/pull/15984#issuecomment-2860488095
1 more PR, then this should be done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
qstommyshu opened a new pull request, #15984:
URL: https://github.com/apache/datafusion/pull/15984
## Which issue does this PR close?
- Related #15396 , #15446, #15884, #15893, #15937, #15945
## Rationale for this change
## What changes are included in thi
