Copilot commented on code in PR #15984:
URL: https://github.com/apache/datafusion/pull/15984#discussion_r2080588006
##########
datafusion/optimizer/src/test/mod.rs:
##########
@@ -99,29 +99,20 @@ pub fn get_tpch_table_schema(table: &str) -> Schema {
}
}
Review Comment:
[nitpick] Consider adding inline documentation for the new macro
'assert_analyzed_plan_with_config_eq_snapshot' to clarify its parameters and
usage for maintainability purposes.
```suggestion
/// This macro is used to analyze a logical plan using a specific analyzer
rule and configuration options,
/// and then compare the resulting analyzed plan to an expected snapshot.
///
/// # Parameters
/// - `$options`: The configuration options (`ConfigOptions`) to use during
analysis.
/// - `$rule`: The analyzer rule (`Arc<dyn AnalyzerRule>`) to apply to the
logical plan.
/// - `$plan`: The logical plan (`LogicalPlan`) to analyze.
/// - `$expected`: A string literal representing the expected snapshot of
the analyzed plan.
///
/// # Example
/// ```
/// let options = ConfigOptions::default();
/// let rule = Arc::new(MyAnalyzerRule {});
/// let plan = LogicalPlan::default();
/// assert_analyzed_plan_with_config_eq_snapshot!(
/// options,
/// rule,
/// plan,
/// @r###"Expected snapshot content"###,
/// );
/// ```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
