Re: [PR] Make Expr::alias and alias_qualified smarter by calling unalias [datafusion]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #14749: Make Expr::alias and alias_qualified smarter by calling unalias URL: https://github.com/apache/datafusion/pull/14749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Make Expr::alias and alias_qualified smarter by calling unalias [datafusion]

2025-04-29 Thread via GitHub
github-actions[bot] commented on PR #14749: URL: https://github.com/apache/datafusion/pull/14749#issuecomment-2840626173 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] Make Expr::alias and alias_qualified smarter by calling unalias [datafusion]

2025-02-25 Thread via GitHub
joroKr21 commented on PR #14749: URL: https://github.com/apache/datafusion/pull/14749#issuecomment-2682651670 The strange part is that the plan before this PR looks like this: ``` plan Projection: __unnest_placeholder(make_array(Int64(1),Int64(2),Int64(3)),depth=1) AS UNNEST(make_arra

Re: [PR] Make Expr::alias and alias_qualified smarter by calling unalias [datafusion]

2025-02-25 Thread via GitHub
joroKr21 commented on PR #14749: URL: https://github.com/apache/datafusion/pull/14749#issuecomment-2682642287 > I think if it is only the plans that change, then it is ok -- if any results (or column names in output) change then it is likely needs more study The column name of the out

Re: [PR] Make Expr::alias and alias_qualified smarter by calling unalias [datafusion]

2025-02-25 Thread via GitHub
alamb commented on PR #14749: URL: https://github.com/apache/datafusion/pull/14749#issuecomment-2682619507 Sorry @joroKr21 for the delayed review I think if it is only the plans that change, then it is ok -- if any results (or column names in output) change then it is likely needs mo

Re: [PR] Make Expr::alias and alias_qualified smarter by calling unalias [datafusion]

2025-02-25 Thread via GitHub
alamb commented on PR #14749: URL: https://github.com/apache/datafusion/pull/14749#issuecomment-2682616129 > Marking this ready for review because I need some feedback. It looks like `plan_to_sql` relies on these nested aliases in a non-trivial way. Is this intended? I think so -- th

Re: [PR] Make Expr::alias and alias_qualified smarter by calling unalias [datafusion]

2025-02-20 Thread via GitHub
joroKr21 commented on PR #14749: URL: https://github.com/apache/datafusion/pull/14749#issuecomment-2671067679 Marking this ready for review because I need some feedback. It looks like `plan_to_sql` relies on these nested aliases in a non-trivial way. Is this intended? ``` roundtrip sq

[PR] Make Expr::alias and alias_qualified smarter by calling unalias [datafusion]

2025-02-18 Thread via GitHub
joroKr21 opened a new pull request, #14749: URL: https://github.com/apache/datafusion/pull/14749 I can't imagine a use case where we want to have double aliasing ## Which issue does this PR close? - Closes #. ## Rationale for this change ## What cha