joroKr21 commented on PR #14749: URL: https://github.com/apache/datafusion/pull/14749#issuecomment-2671067679
Marking this ready for review because I need some feedback. It looks like `plan_to_sql` relies on these nested aliases in a non-trivial way. Is this intended? ``` roundtrip sql: SELECT * FROM UNNEST([1, 2, 3]) plan Projection: __unnest_placeholder(make_array(Int64(1),Int64(2),Int64(3)),depth=1) AS c1 Unnest: lists[__unnest_placeholder(make_array(Int64(1),Int64(2),Int64(3)))|depth=1] structs[] Projection: make_array(Int64(1), Int64(2), Int64(3)) AS __unnest_placeholder(make_array(Int64(1),Int64(2),Int64(3))) EmptyRelation thread 'cases::plan_to_sql::roundtrip_statement_with_dialect' panicked at datafusion/sql/tests/cases/plan_to_sql.rs:679:9: assertion `left == right` failed left: "SELECT UNNEST([1, 2, 3]) AS c1" right: "SELECT * FROM UNNEST([1, 2, 3])" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org