alamb commented on PR #16386:
URL: https://github.com/apache/datafusion/pull/16386#issuecomment-2982071425
@blaginin also did an end to end test with S3 in the CI tests. The
instructions are here:
-
https://github.com/apache/datafusion/blob/main/datafusion-cli/CONTRIBUTING.md#L30-L
alamb commented on PR #16386:
URL: https://github.com/apache/datafusion/pull/16386#issuecomment-2982068035
> > > @alamb Could you help reivew this PR?
> >
> >
> > Thanks @xiedeyantu ! We normally need to add tests as part of any code
PR -- could you look into adding some tests and
xiedeyantu commented on PR #16386:
URL: https://github.com/apache/datafusion/pull/16386#issuecomment-2978374953
> > @alamb Could you help reivew this PR?
>
> Thanks @xiedeyantu ! We normally need to add tests as part of any code PR
-- could you look into adding some tests and document
alamb commented on PR #16386:
URL: https://github.com/apache/datafusion/pull/16386#issuecomment-2978264463
> @alamb Could you help reivew this PR?
Thanks @xiedeyantu ! We normally need to add tests as part of any code PR
-- could you look into adding some tests and documentation abou
xiedeyantu commented on PR #16386:
URL: https://github.com/apache/datafusion/pull/16386#issuecomment-2976974834
@alamb Could you help reivew this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
xiedeyantu opened a new pull request, #16386:
URL: https://github.com/apache/datafusion/pull/16386
## Which issue does this PR close?
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes test
