alamb commented on PR #16386: URL: https://github.com/apache/datafusion/pull/16386#issuecomment-2982068035
> > > @alamb Could you help reivew this PR? > > > > > > Thanks @xiedeyantu ! We normally need to add tests as part of any code PR -- could you look into adding some tests and documentation about how this change works? > > @alamb Is there any example I can refer to for testing involving s3, because real access requires ak/sk and the real path? I think you can follow the one here: https://datafusion.apache.org/user-guide/cli/datasources.html#s3 > To read from a public S3 bucket without signatures, use the aws.SKIP_SIGNATURE option: ```sql CREATE EXTERNAL TABLE nyc_taxi_rides STORED AS PARQUET LOCATION 's3://altinity-clickhouse-data/nyc_taxi_rides/data/tripdata_parquet/' OPTIONS(aws.SKIP_SIGNATURE true); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
