iffyio commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2071047425
##
src/parser/mod.rs:
##
@@ -716,20 +734,36 @@ impl<'a> Parser<'a> {
let condition = match &start_token.token {
Token::Word(w) i
iffyio merged PR #1831:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2068787347
##
src/test_utils.rs:
##
@@ -166,6 +168,30 @@ impl TestedDialects {
only_statement
}
+/// The same as [`one_statement_parses_to`]
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2068774017
##
src/test_utils.rs:
##
@@ -166,6 +168,30 @@ impl TestedDialects {
only_statement
}
+/// The same as [`one_statement_parses_to`]
iffyio commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067910538
##
src/test_utils.rs:
##
@@ -166,6 +168,30 @@ impl TestedDialects {
only_statement
}
+/// The same as [`one_statement_parses_to`] bu
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067496065
##
tests/sqlparser_mssql.rs:
##
@@ -1393,6 +1394,85 @@ fn parse_mssql_declare() {
let _ = ms().verified_stmt(declare_cursor_for_select);
}
+#
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067493757
##
src/ast/mod.rs:
##
@@ -4225,11 +4267,10 @@ impl fmt::Display for Statement {
Statement::Fetch {
name,
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067470750
##
src/parser/mod.rs:
##
@@ -4453,6 +4487,9 @@ impl<'a> Parser<'a> {
break;
}
}
+if le
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067467383
##
src/parser/mod.rs:
##
@@ -8735,6 +8779,14 @@ impl<'a> Parser<'a> {
})
}
+/// Parse [Statement::Open]
Review Comment:
Done
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067462307
##
src/parser/mod.rs:
##
@@ -8735,6 +8779,14 @@ impl<'a> Parser<'a> {
})
}
+/// Parse [Statement::Open]
Review Comment:
It's
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067461233
##
src/test_utils.rs:
##
@@ -166,6 +168,30 @@ impl TestedDialects {
only_statement
}
+/// The same as [`one_statement_parses_to`]
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067459659
##
tests/sqlparser_mssql.rs:
##
@@ -1393,6 +1393,52 @@ fn parse_mssql_declare() {
let _ = ms().verified_stmt(declare_cursor_for_select);
}
+#
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067442898
##
tests/sqlparser_mssql.rs:
##
@@ -1393,6 +1393,52 @@ fn parse_mssql_declare() {
let _ = ms().verified_stmt(declare_cursor_for_select);
}
+#
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067410508
##
src/ast/mod.rs:
##
@@ -3032,6 +3068,14 @@ pub enum Statement {
partition: Option>,
},
/// ```sql
+/// OPEN cursor_name
+
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067391534
##
src/ast/mod.rs:
##
@@ -3403,6 +3447,10 @@ pub enum Statement {
/// Cursor name
name: Ident,
direction: FetchDirection,
iffyio commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2067185362
##
src/test_utils.rs:
##
@@ -166,6 +168,30 @@ impl TestedDialects {
only_statement
}
+/// The same as [`one_statement_parses_to`] bu
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2064175724
##
src/ast/mod.rs:
##
@@ -3403,6 +3447,10 @@ pub enum Statement {
/// Cursor name
name: Ident,
direction: FetchDirection,
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2064175279
##
src/ast/mod.rs:
##
@@ -3032,6 +3068,14 @@ pub enum Statement {
partition: Option>,
},
/// ```sql
+/// OPEN cursor_name
+
aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2064171122
##
src/ast/mod.rs:
##
@@ -2226,7 +2226,33 @@ impl fmt::Display for IfStatement {
}
}
-/// A block within a [Statement::Case] or [Statement::I
aharpervc opened a new pull request, #1831:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1831
This PR is a followup to
https://github.com/apache/datafusion-sqlparser-rs/pull/1821 to address several
difficulties I had parsing real world SQL files.
There are 3 related en
20 matches
Mail list logo
