aharpervc commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2068774017
##########
src/test_utils.rs:
##########
@@ -166,6 +168,30 @@ impl TestedDialects {
only_statement
}
+ /// The same as [`one_statement_parses_to`] but it works for a multiple
statements
+ pub fn statements_parse_to(
+ &self,
+ sql: &str,
+ statement_count: usize,
+ canonical: &str,
+ ) -> Vec<Statement> {
+ let statements = self.parse_sql_statements(sql).expect(sql);
+ assert_eq!(statements.len(), statement_count);
Review Comment:
> Then in this case, we're doing so implicitly, reconstructing the input sql
based off the returned statement ... So that i imagine it shouldn't be possible
for the count assertion to fail and either of the subsequent assertion to pass?
I will remove the assertion here to get this branch merged. However, I think
removing it removes a level of safety that is beneficial. Part of my thinking
here is motivated by my upcoming branch on making semi colon statement
delimiters optional. So any code that is making assumptions about "number of
statements" becomes even more useful.
But perhaps that branch can re-introduce that assertion if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
