github-actions[bot] closed pull request #13249: improve eliminate_outer_join
rule
URL: https://github.com/apache/datafusion/pull/13249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
github-actions[bot] commented on PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#issuecomment-2814346885
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
suibianwanwank commented on code in PR #15254:
URL: https://github.com/apache/datafusion/pull/15254#discussion_r1997659534
##
datafusion/expr/src/utils.rs:
##
@@ -1000,6 +1000,107 @@ pub fn can_hash(data_type: &DataType) -> bool {
}
}
+/// Metadata for the columns should
suibianwanwank closed pull request #15254: Improve eliminate_outer_join rule
URL: https://github.com/apache/datafusion/pull/15254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Dandandan commented on code in PR #15254:
URL: https://github.com/apache/datafusion/pull/15254#discussion_r1997646536
##
datafusion/expr/src/utils.rs:
##
@@ -1000,6 +1000,107 @@ pub fn can_hash(data_type: &DataType) -> bool {
}
}
+/// Metadata for the columns should be n
suibianwanwank opened a new pull request, #15254:
URL: https://github.com/apache/datafusion/pull/15254
## Which issue does this PR close?
- Closes #13232
## Rationale for this change
Inspired by the approach in #13249. This PR explores an alternative that
does not r
Blizzara commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1954912194
##
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##
@@ -292,10 +292,10 @@ async fn decimal_literal() -> Result<()> {
roundtrip("SELECT * FROM d
github-actions[bot] commented on PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#issuecomment-2644423972
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
JasonLi-cn commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1847602836
##
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##
@@ -292,10 +292,10 @@ async fn decimal_literal() -> Result<()> {
roundtrip("SELECT * FROM
Blizzara commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1846618012
##
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##
@@ -292,10 +292,10 @@ async fn decimal_literal() -> Result<()> {
roundtrip("SELECT * FROM d
eejbyfeldt commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1834447949
##
datafusion/optimizer/src/utils.rs:
##
@@ -129,73 +125,57 @@ pub fn log_plan(description: &str, plan: &LogicalPlan) {
/// `c0 > 8` return true;
/// `c0 IS N
eejbyfeldt commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1834443482
##
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##
@@ -1675,12 +1675,34 @@ impl<'a, S: SimplifyInfo> TreeNodeRewriter for
Simplifier<'a, S
eejbyfeldt commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1834439966
##
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##
@@ -1675,12 +1675,34 @@ impl<'a, S: SimplifyInfo> TreeNodeRewriter for
Simplifier<'a, S
eejbyfeldt commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1834438317
##
datafusion/optimizer/src/eliminate_outer_join.rs:
##
@@ -443,4 +361,214 @@ mod tests {
\nTableScan: t2";
assert_optimized_plan_equal(pl
eejbyfeldt commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1834435092
##
datafusion/optimizer/src/eliminate_outer_join.rs:
##
@@ -443,4 +361,214 @@ mod tests {
\nTableScan: t2";
assert_optimized_plan_equal(pl
JasonLi-cn commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1828713330
##
datafusion/optimizer/src/utils.rs:
##
@@ -129,52 +128,32 @@ pub fn log_plan(description: &str, plan: &LogicalPlan) {
/// `c0 > 8` return true;
/// `c0 IS N
JasonLi-cn commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1828621048
##
datafusion/optimizer/src/utils.rs:
##
@@ -129,52 +128,32 @@ pub fn log_plan(description: &str, plan: &LogicalPlan) {
/// `c0 > 8` return true;
/// `c0 IS N
JasonLi-cn commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1828619074
##
datafusion/optimizer/src/eliminate_outer_join.rs:
##
@@ -443,4 +361,214 @@ mod tests {
\nTableScan: t2";
assert_optimized_plan_equal(pl
JasonLi-cn commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1828614538
##
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##
@@ -1675,12 +1675,34 @@ impl<'a, S: SimplifyInfo> TreeNodeRewriter for
Simplifier<'a, S
JasonLi-cn commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1828609903
##
datafusion/optimizer/src/utils.rs:
##
@@ -129,52 +128,32 @@ pub fn log_plan(description: &str, plan: &LogicalPlan) {
/// `c0 > 8` return true;
/// `c0 IS N
JasonLi-cn commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1828603512
##
datafusion/optimizer/src/eliminate_outer_join.rs:
##
@@ -443,4 +361,214 @@ mod tests {
\nTableScan: t2";
assert_optimized_plan_equal(pl
eejbyfeldt commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1828347437
##
datafusion/optimizer/src/eliminate_outer_join.rs:
##
@@ -443,4 +361,214 @@ mod tests {
\nTableScan: t2";
assert_optimized_plan_equal(pl
eejbyfeldt commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1828345457
##
datafusion/optimizer/src/eliminate_outer_join.rs:
##
@@ -443,4 +361,214 @@ mod tests {
\nTableScan: t2";
assert_optimized_plan_equal(pl
JasonLi-cn commented on PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#issuecomment-2455032712
[the substrait bug](https://github.com/apache/datafusion/issues/13251)
blocks the current PR from passing `null_decimal_literal` test.
--
This is an automated message from t
Dandandan commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1827792383
##
datafusion/optimizer/src/eliminate_outer_join.rs:
##
@@ -56,6 +59,138 @@ impl EliminateOuterJoin {
pub fn new() -> Self {
Self {}
}
+
+
JasonLi-cn commented on PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#issuecomment-2454791443
This is an experiment, and i need help to determine if this solution is
feasible. If feasible, I will:
- improve `expr_simplifier`
- add test
- fix the substrait bug for
JasonLi-cn opened a new pull request, #13249:
URL: https://github.com/apache/datafusion/pull/13249
improve eliminate_outer_join rule
## Which issue does this PR close?
Closes https://github.com/apache/datafusion/issues/13232
## Rationale for this change
27 matches
Mail list logo
