Blizzara commented on code in PR #13249:
URL: https://github.com/apache/datafusion/pull/13249#discussion_r1846618012
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -292,10 +292,10 @@ async fn decimal_literal() -> Result<()> {
roundtrip("SELECT * FROM data WHERE b > 2.5").await
}
-#[tokio::test]
-async fn null_decimal_literal() -> Result<()> {
- roundtrip("SELECT * FROM data WHERE b = NULL").await
-}
+// #[tokio::test]
+// async fn null_decimal_literal() -> Result<()> {
+// roundtrip("SELECT * FROM data WHERE b = NULL").await
+// }
Review Comment:
this would work to avoid commenting this out:
```suggestion
#[tokio::test]
async fn null_decimal_literal() -> Result<()> {
roundtrip("SELECT * FROM data WHERE b != NULL").await
}
```
or altenatively something like
`roundtrip("SELECT CAST(null AS DECIMAL(3, 2)) FROM data").await` works as
well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
