goldmedal closed pull request #14864: Fixed Migrate Datetime functions to
invoke_with_args Issue 14705
URL: https://github.com/apache/datafusion/pull/14864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb commented on PR #14864:
URL: https://github.com/apache/datafusion/pull/14864#issuecomment-2683165379
I think this may be a dupe of
- https://github.com/apache/datafusion/pull/14876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
varun-bhardwaj-sde opened a new pull request, #14864:
URL: https://github.com/apache/datafusion/pull/14864
## Which issue does this PR close?
- Closes #14705.
## Rationale for this change
## What changes are included in this PR?
## Are t
varun-bhardwaj-sde commented on PR #14864:
URL: https://github.com/apache/datafusion/pull/14864#issuecomment-2680507929
@niebayes can you please review this once and guide me if I am doing any
mistake here
--
This is an automated message from the Apache Git Service.
To respond to the mess
varun-bhardwaj-sde commented on PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#issuecomment-2680505232
it was closed by misktake i raised another PR
https://github.com/apache/datafusion/pull/14864 for this task
--
This is an automated message from the Apache Git Service.
varun-bhardwaj-sde closed pull request #14792: Fixed Migrate Datetime functions
to invoke_with_args Issue 14705
URL: https://github.com/apache/datafusion/pull/14792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb commented on PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#issuecomment-2674391632
Thank you @niebayes for helping with the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
alamb commented on PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#issuecomment-2674391408
Marking as draft as I think this PR is no longer waiting on feedback. Please
mark it as ready for review when it is ready for another look
--
This is an automated message from the A
niebayes commented on code in PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#discussion_r1964634594
##
datafusion/functions/src/datetime/current_date.rs:
##
@@ -81,16 +81,19 @@ impl ScalarUDFImpl for CurrentDateFunc {
Ok(Date32)
}
-fn invoke_
goldmedal commented on PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#issuecomment-2671594771
> sir @goldmedal @alamb i am new in rust and this will be my first
contribution please check my code and let me know if it is right or wrong ,i
want to merge this change if there a
varun-bhardwaj-sde commented on PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#issuecomment-2671561680
sir @goldmedal @alamb i am new in rust and this will be my first
contribution please check my code and let me know if it is right or wrong ,i
want to merge this change i
varun-bhardwaj-sde opened a new pull request, #14792:
URL: https://github.com/apache/datafusion/pull/14792
## Which issue does this PR close?
- Closes #14705.
## Rationale for this change
## What changes are included in this PR?
## Are these
12 matches
Mail list logo
