niebayes commented on code in PR #14792:
URL: https://github.com/apache/datafusion/pull/14792#discussion_r1964634594
##########
datafusion/functions/src/datetime/current_date.rs:
##########
@@ -81,16 +81,19 @@ impl ScalarUDFImpl for CurrentDateFunc {
Ok(Date32)
}
- fn invoke_batch(
- &self,
- _args: &[ColumnarValue],
- _number_rows: usize,
- ) -> Result<ColumnarValue> {
- internal_err!(
- "invoke should not be called on a simplified current_date()
function"
- )
+ fn invoke_with_args(&self, args: &[ColumnarValue]) -> Result<ColumnarValue>
{
Review Comment:
The signature of the `invoke_with_args` should be:
```
fn invoke_with_args(&self, args: ScalarFunctionArgs) ->
Result<ColumnarValue>.
```
You can check the `ScalarUDFImpl` trait in the datafusion::expr::udf crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
