Re: [PR] Fix WindowFrame::new with order_by [datafusion]

2025-06-25 Thread via GitHub
alamb commented on code in PR #16537: URL: https://github.com/apache/datafusion/pull/16537#discussion_r2164786735 ## datafusion/expr/src/window_state.rs: ## @@ -232,7 +232,7 @@ impl WindowFrameContext { } // ERRONEOUS FRAMES WindowFrameBoun

Re: [PR] Fix WindowFrame::new with order_by [datafusion]

2025-06-25 Thread via GitHub
findepi merged PR #16537: URL: https://github.com/apache/datafusion/pull/16537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafu

[PR] Fix WindowFrame::new with order_by [datafusion]

2025-06-24 Thread via GitHub
findepi opened a new pull request, #16537: URL: https://github.com/apache/datafusion/pull/16537 ## Which issue does this PR close? - Closes #. ## Rationale for this change Before the change, the frame constructed with `WindowFrame::new(Some(true))` would not be