alamb commented on code in PR #16537:
URL: https://github.com/apache/datafusion/pull/16537#discussion_r2164786735
##########
datafusion/expr/src/window_state.rs:
##########
@@ -232,7 +232,7 @@ impl WindowFrameContext {
}
// ERRONEOUS FRAMES
WindowFrameBound::Preceding(_) | WindowFrameBound::Following(_) =>
{
- return internal_err!("Rows should be Uint")
+ return internal_err!("Rows should be UInt64")
Review Comment:
👍
##########
datafusion/expr/src/window_state.rs:
##########
@@ -697,25 +697,157 @@ mod tests {
Ok(())
}
+ fn assert_frame_ranges(
Review Comment:
I verified that these tests fail without the changes in this PR
```
/Users/andrewlamb/.cargo/bin/cargo test --color=always --lib
window_state::tests --profile test --no-fail-fast --config
target.aarch64-apple-darwin.runner=['/Applications/RustRover.app/Contents/bin/native-helper/intellij-rust-native-helper']
--manifest-path
/Users/andrewlamb/Software/datafusion/datafusion/expr/Cargo.toml --
--format=json -Z unstable-options --show-output
Testing started at 3:55 PM ...
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.11s
Running unittests src/lib.rs
(target/debug/deps/datafusion_expr-7882f1b4d9e3db1f)
Error: Internal("Rows should be UInt64")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
