parthchandra commented on PR #1901:
URL:
https://github.com/apache/datafusion-comet/pull/1901#issuecomment-3006474262
I don't think this PR is making the correct change.
With this PR the removed test fails to execute the query (let alone pass the
assertion)
```
test("SortMergeJo
parthchandra commented on code in PR #1901:
URL: https://github.com/apache/datafusion-comet/pull/1901#discussion_r2167482793
##
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala:
##
@@ -54,25 +54,6 @@ class CometJoinSuite extends CometTestBase {
.toSeq)
SKY-ALIN commented on code in PR #1901:
URL: https://github.com/apache/datafusion-comet/pull/1901#discussion_r2164969731
##
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala:
##
@@ -54,25 +54,6 @@ class CometJoinSuite extends CometTestBase {
.toSeq)
}
parthchandra commented on code in PR #1901:
URL: https://github.com/apache/datafusion-comet/pull/1901#discussion_r2164519556
##
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala:
##
@@ -54,25 +54,6 @@ class CometJoinSuite extends CometTestBase {
.toSeq)
SKY-ALIN commented on code in PR #1901:
URL: https://github.com/apache/datafusion-comet/pull/1901#discussion_r2160644398
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2168,7 +2168,8 @@ object QueryPlanSerde extends Logging with CometExprShim {
*
SKY-ALIN commented on PR #1901:
URL:
https://github.com/apache/datafusion-comet/pull/1901#issuecomment-2994779058
@mbutrovich done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
codecov-commenter commented on PR #1901:
URL:
https://github.com/apache/datafusion-comet/pull/1901#issuecomment-2986286369
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1901?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
parthchandra commented on PR #1901:
URL:
https://github.com/apache/datafusion-comet/pull/1901#issuecomment-2985979040
> Thanks for the contribution, @SKY-ALIN! Could we add a test case with
timestamps as the join key?
The test should have the left side and the right side timestamps b
andygrove commented on code in PR #1901:
URL: https://github.com/apache/datafusion-comet/pull/1901#discussion_r2154673214
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2168,7 +2168,8 @@ object QueryPlanSerde extends Logging with CometExprShim {
mbutrovich commented on PR #1901:
URL:
https://github.com/apache/datafusion-comet/pull/1901#issuecomment-2984157981
Could we add a test case with timestamps as the join key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SKY-ALIN commented on PR #1901:
URL:
https://github.com/apache/datafusion-comet/pull/1901#issuecomment-2983795662
It fixes formatting also, now it looks like this:
```shell
25/06/18 12:53:47 WARN CometExecRule: Comet cannot execute some parts of
this plan natively (set spark.comet
SKY-ALIN opened a new pull request, #1901:
URL: https://github.com/apache/datafusion-comet/pull/1901
## Which issue does this PR close?
Closes #1900.
## Rationale for this change
This type is supported, but missed on the proto stage + message formatting
is incorr
12 matches
Mail list logo
