SKY-ALIN commented on code in PR #1901: URL: https://github.com/apache/datafusion-comet/pull/1901#discussion_r2164969731
########## spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala: ########## @@ -54,25 +54,6 @@ class CometJoinSuite extends CometTestBase { .toSeq) } - test("SortMergeJoin with unsupported key type should fall back to Spark") { Review Comment: Such a test will not work as the current implementation of datafusion doesn't include this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org