Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
jayzhan211 commented on code in PR #14881: URL: https://github.com/apache/datafusion/pull/14881#discussion_r1970785236 ## datafusion/sqllogictest/README.md: ## @@ -243,6 +243,14 @@ export RUST_MIN_STACK=30485760; PG_COMPAT=true INCLUDE_SQLITE=true cargo test --features=postgres

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
Omega359 commented on code in PR #14881: URL: https://github.com/apache/datafusion/pull/14881#discussion_r1970798347 ## datafusion/sqllogictest/README.md: ## @@ -243,6 +243,14 @@ export RUST_MIN_STACK=30485760; PG_COMPAT=true INCLUDE_SQLITE=true cargo test --features=postgres -

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
jayzhan211 commented on code in PR #14881: URL: https://github.com/apache/datafusion/pull/14881#discussion_r1970785236 ## datafusion/sqllogictest/README.md: ## @@ -243,6 +243,14 @@ export RUST_MIN_STACK=30485760; PG_COMPAT=true INCLUDE_SQLITE=true cargo test --features=postgres

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
jayzhan211 commented on code in PR #14881: URL: https://github.com/apache/datafusion/pull/14881#discussion_r1970785236 ## datafusion/sqllogictest/README.md: ## @@ -243,6 +243,14 @@ export RUST_MIN_STACK=30485760; PG_COMPAT=true INCLUDE_SQLITE=true cargo test --features=postgres

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
jayzhan211 merged PR #14881: URL: https://github.com/apache/datafusion/pull/14881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dat

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
jayzhan211 commented on PR #14881: URL: https://github.com/apache/datafusion/pull/14881#issuecomment-2683674514 Thanks @alamb, let me try it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
alamb commented on PR #14881: URL: https://github.com/apache/datafusion/pull/14881#issuecomment-2683458549 @Omega359 has an alternate plan here potentially: https://github.com/apache/datafusion/pull/14824#issuecomment-2683289068 -- This is an automated message from the Apache Git Service

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
alamb commented on PR #14881: URL: https://github.com/apache/datafusion/pull/14881#issuecomment-2683409993 Ok, I think this one now works again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
alamb commented on code in PR #14881: URL: https://github.com/apache/datafusion/pull/14881#discussion_r1970539407 ## datafusion/sqllogictest/regenerate/src/engines/datafusion_engine/runner.rs: ## @@ -0,0 +1,131 @@ +// Licensed to the Apache Software Foundation (ASF) under one R

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
alamb commented on PR #14881: URL: https://github.com/apache/datafusion/pull/14881#issuecomment-2683299551 I am still testing this locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
Omega359 commented on code in PR #14881: URL: https://github.com/apache/datafusion/pull/14881#discussion_r1970539669 ## datafusion/sqllogictest/README.md: ## @@ -243,6 +243,14 @@ export RUST_MIN_STACK=30485760; PG_COMPAT=true INCLUDE_SQLITE=true cargo test --features=postgres -

Re: [PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
alamb commented on code in PR #14881: URL: https://github.com/apache/datafusion/pull/14881#discussion_r1970539614 ## datafusion/sqllogictest/regenerate_sqlite_files.sh: ## @@ -168,8 +168,10 @@ sd -f i '^sqllogictest.*' 'sqllogictest = { git = "https://github.com/Omega359/s e

[PR] Fix `regenerate_sqlite_files.sh` due to changes in sqllogictests [datafusion]

2025-02-25 Thread via GitHub
alamb opened a new pull request, #14881: URL: https://github.com/apache/datafusion/pull/14881 ## Which issue does this PR close? - Part of https://github.com/apache/datafusion/pull/14824 ## Rationale for this change The regeneration logic uses a fork of the sqllogicte