jayzhan211 commented on code in PR #14881:
URL: https://github.com/apache/datafusion/pull/14881#discussion_r1970785236


##########
datafusion/sqllogictest/README.md:
##########
@@ -243,6 +243,14 @@ export RUST_MIN_STACK=30485760;
 PG_COMPAT=true INCLUDE_SQLITE=true cargo test --features=postgres --test 
sqllogictests
 ```
 
+To update the sqllite expected answers use the 
`datafusion/sqllogictest/regenerate_sqlite_files.sh` script.
+
+Note this must be run with an empty postgres instance. For example
+
+```shell
+PG_URI=postgresql://postgres@localhost:5432/postgres bash 
datafusion/sqllogictest/regenerate_sqlite_files.sh
+```

Review Comment:
   `postgresql://postgres@localhost:5432/postgres` doesn't work for me.
   
   Run with `$(whoami)` to find your name, and the command should be
   ```
   PG_URI=postgres://$(whoami)@localhost:5432/{database} bash 
datafusion/sqllogictest/regenerate_sqlite_files.sh
   ```
   
   And run this to find database
   ```
   ➜  datafusion git:(count-schema-name) ✗ psql -U jayzhan -h localhost -p 5432 
-l
                              List of databases
      Name    |  Owner  | Encoding | Collate | Ctype |  Access privileges  
   -----------+---------+----------+---------+-------+---------------------
    postgres  | jayzhan | UTF8     | C       | C     | 
    template0 | jayzhan | UTF8     | C       | C     | =c/jayzhan         +
              |         |          |         |       | jayzhan=CTc/jayzhan
    template1 | jayzhan | UTF8     | C       | C     | =c/jayzhan         +
              |         |          |         |       | jayzhan=CTc/jayzhan
   (3 rows)
   ```
   
   
   
   ```
   PG_URI=postgres://jayzhan@localhost:5432/postgres bash 
datafusion/sqllogictest/regenerate_sqlite_files.sh
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to