alamb commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1934326726
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -6203,3 +6203,97 @@ physical_plan
14)--PlaceholderRowExec
15)ProjectionExec: exp
alamb commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1934314846
##
datafusion/functions-aggregate/src/min_max.rs:
##
@@ -1183,6 +1187,10 @@ impl AggregateUDFImpl for Min {
fn documentation(&self) -> Option<&Documentation> {
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1934074103
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -4978,17 +4981,19 @@ logical_plan
physical_plan
01)GlobalLimitExec: skip=0, fetch=5
02)--Coales
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1934073481
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -4963,6 +4963,9 @@ false
true
NULL
+statement ok
Review Comment:
done
--
This is an au
ozankabak commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1933977485
##
datafusion/physical-expr/src/window/standard.rs:
##
@@ -65,33 +65,19 @@ impl StandardWindowExpr {
&self.expr
}
-/// Adds any equivalent or
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1932128811
##
datafusion/sqllogictest/test_files/aggregates_topk.slt:
##
@@ -143,13 +143,12 @@ logical_plan
03)TableScan: traces projection=[trace_id, timestamp]
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1932023820
##
datafusion/expr/src/udaf.rs:
##
@@ -635,6 +655,14 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
fn documentation(&self) -> Option<&Documentati
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1932037809
##
datafusion/expr/src/udaf.rs:
##
@@ -635,6 +655,14 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
fn documentation(&self) -> Option<&Documentati
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1932023820
##
datafusion/expr/src/udaf.rs:
##
@@ -635,6 +655,14 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
fn documentation(&self) -> Option<&Documentati
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1932018364
##
datafusion/expr/src/udaf.rs:
##
@@ -39,6 +39,26 @@ use crate::utils::AggregateOrderSensitivity;
use crate::{Accumulator, Expr};
use crate::{Documentatio
alamb commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1929720287
##
datafusion/expr/src/udaf.rs:
##
@@ -39,6 +39,26 @@ use crate::utils::AggregateOrderSensitivity;
use crate::{Accumulator, Expr};
use crate::{Documentation, Signa
2010YOUY01 commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1929505898
##
datafusion/expr/src/udaf.rs:
##
@@ -635,6 +655,14 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
fn documentation(&self) -> Option<&Documentation>
12 matches
Mail list logo
