berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1932023820
##########
datafusion/expr/src/udaf.rs:
##########
@@ -635,6 +655,14 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
fn documentation(&self) -> Option<&Documentation> {
None
}
+
+ /// Indicates whether the aggregation function is monotonic as a set
function. A set
+ /// function is monotonically increasing if its value increases as its
argument grows
+ /// (as a set). Formally, `f` is a monotonically increasing set function
if `f(S) >= f(T)`
+ /// whenever `S` is a superset of `T`.
+ fn monotonicity(&self, _data_type: &DataType) -> AggregateExprMonotonicity
{
Review Comment:
I think this is not possible because this property is purely related with
the function's nature. It does not depend input order or anything else, just
the relation between the element-wise increment (or decrement) in the grouping
set and resulting values of aggregate function. I'm renaming the monotonicity
as set-monotonicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
