Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-28 Thread via GitHub
andygrove merged PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-28 Thread via GitHub
andygrove commented on code in PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#discussion_r1932315212 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2701,4 +2701,25 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-27 Thread via GitHub
erenavsarogullari commented on PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#issuecomment-2617922084 FYI, Currently, DataFusion does not support `arrays_overlap` function but supports same functionality by `array_has_any` function. Other query engines like `Snowflake`

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-27 Thread via GitHub
erenavsarogullari commented on PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#issuecomment-2617918532 > @erenavsarogullari could you rebase this PR when you have time? We can go ahead and merge this and then improve tests as part of #1269 Thanks @andygrove and @k

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-27 Thread via GitHub
erenavsarogullari commented on code in PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#discussion_r1931542657 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2568,4 +2568,21 @@ class CometExpressionSuite extends CometTestBase with

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-27 Thread via GitHub
erenavsarogullari commented on code in PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#discussion_r1931542331 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -2300,6 +2300,12 @@ object QueryPlanSerde extends Logging with ShimQueryP

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-27 Thread via GitHub
andygrove commented on code in PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#discussion_r1931285115 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -2300,6 +2300,12 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-27 Thread via GitHub
andygrove commented on code in PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#discussion_r1931280635 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -2300,6 +2300,12 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-27 Thread via GitHub
kazuyukitanimura commented on code in PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#discussion_r1931238764 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -2300,6 +2300,12 @@ object QueryPlanSerde extends Logging with ShimQueryPl

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-27 Thread via GitHub
andygrove commented on PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#issuecomment-2616601186 @erenavsarogullari could you rebase this PR when you have time? We can go ahead and merge this and then improve tests as part of https://github.com/apache/datafusion-comet/iss

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-21 Thread via GitHub
andygrove commented on code in PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#discussion_r1924572159 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -2300,6 +2300,12 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-21 Thread via GitHub
andygrove commented on code in PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#discussion_r1924572763 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2568,4 +2568,21 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-20 Thread via GitHub
codecov-commenter commented on PR #1312: URL: https://github.com/apache/datafusion-comet/pull/1312#issuecomment-2601822449 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1312?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

[PR] Feat: Support arrays_overlap function [datafusion-comet]

2025-01-20 Thread via GitHub
erenavsarogullari opened a new pull request, #1312: URL: https://github.com/apache/datafusion-comet/pull/1312 ## Which issue does this PR close? Related to Epic: https://github.com/apache/datafusion-comet/issues/1042 `arrays_overlap`: `select arrays_overlap(array('hello', '-', 'world'),