andygrove commented on code in PR #1312:
URL: https://github.com/apache/datafusion-comet/pull/1312#discussion_r1924572763


##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2568,4 +2568,21 @@ class CometExpressionSuite extends CometTestBase with 
AdaptiveSparkPlanHelper {
       }
     }
   }
+
+  test("arrays_overlap") {

Review Comment:
   Could you add tests where one or both input expressions evaluate to null on 
some rows? This can be achieved with a CASE expression as in some of the other 
array tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to