goldmedal commented on PR #15334:
URL: https://github.com/apache/datafusion/pull/15334#issuecomment-2818265303
> @goldmedal I don't understand this change. Previously, we have a sql:
>
> ```
> select * from t
> where (select sid from t) = (select a from t limit 1)
> order by t
niebayes commented on PR #15334:
URL: https://github.com/apache/datafusion/pull/15334#issuecomment-2817844756
I don't understand this change.
Previously, we have a sql:
```
select * from t
where (select sid from t) = (select a from t limit 1)
order by ts
```
which defini
comphead commented on code in PR #15334:
URL: https://github.com/apache/datafusion/pull/15334#discussion_r2009201610
##
datafusion/sqllogictest/test_files/join.slt.part:
##
@@ -625,6 +625,24 @@ FROM t1
11 11 11
+# join condition is required
+# TODO: query error join con
alamb merged PR #15334:
URL: https://github.com/apache/datafusion/pull/15334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
goldmedal commented on PR #15334:
URL: https://github.com/apache/datafusion/pull/15334#issuecomment-2752894014
Thanks @comphead and @alamb 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
goldmedal commented on code in PR #15334:
URL: https://github.com/apache/datafusion/pull/15334#discussion_r2009971193
##
datafusion/sqllogictest/test_files/limit.slt:
##
@@ -723,14 +723,14 @@ statement ok
create table testSubQueryLimit (a int, b int) as values (1,2), (2,3), (3,
comphead commented on code in PR #15334:
URL: https://github.com/apache/datafusion/pull/15334#discussion_r2009201037
##
datafusion/sqllogictest/test_files/limit.slt:
##
@@ -723,14 +723,14 @@ statement ok
create table testSubQueryLimit (a int, b int) as values (1,2), (2,3), (3,4
goldmedal commented on code in PR #15334:
URL: https://github.com/apache/datafusion/pull/15334#discussion_r2008714660
##
datafusion/sqllogictest/test_files/tpch/plans/q22.slt.part:
##
@@ -65,7 +65,7 @@ logical_plan
07)Projection: customer.c_phone, customer.c_acctbal
goldmedal opened a new pull request, #15334:
URL: https://github.com/apache/datafusion/pull/15334
## Which issue does this PR close?
- Closes #13486
## Rationale for this change
When working on unparsing the plan optimized by `ScalarSubqueryToJoin`, I
notice
goldmedal commented on code in PR #15334:
URL: https://github.com/apache/datafusion/pull/15334#discussion_r2005913705
##
datafusion/optimizer/src/push_down_limit.rs:
##
@@ -861,167 +849,6 @@ mod test {
assert_optimized_plan_equal(outer_query, expected)
}
-#[t
10 matches
Mail list logo
