comphead commented on code in PR #15334: URL: https://github.com/apache/datafusion/pull/15334#discussion_r2009201610
########## datafusion/sqllogictest/test_files/join.slt.part: ########## @@ -625,6 +625,24 @@ FROM t1 ---- 11 11 11 +# join condition is required +# TODO: query error join condition should not be empty +# related to: https://github.com/apache/datafusion/issues/13486 +statement ok +SELECT * FROM t1 JOIN t2 + +# join condition is required +query error join condition should not be empty +SELECT * FROM t1 LEFT JOIN t2 + +# join condition is required +query error join condition should not be empty +SELECT * FROM t1 RIGHT JOIN t2 + +# join condition is required +query error join condition should not be empty +SELECT * FROM t1 FULL JOIN t2 Review Comment: Please include also a cross join without filters like ``` SELECT * FROM t1 CROSS JOIN t2 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
