[PR] Count alias [datafusion]

2025-03-02 Thread via GitHub
jayzhan211 opened a new pull request, #14927: URL: https://github.com/apache/datafusion/pull/14927 ## Which issue does this PR close? - Closes #14894. ## Rationale for this change ## What changes are included in this PR? ## Are these cha

Re: [PR] Count alias [datafusion]

2025-02-27 Thread via GitHub
jayzhan211 commented on code in PR #14927: URL: https://github.com/apache/datafusion/pull/14927#discussion_r1974873043 ## datafusion/sqllogictest/test_files/subquery.slt: ## @@ -1393,3 +1393,37 @@ item1 1970-01-01T00:00:03 75 statement ok drop table source_table; + +# test c

Re: [PR] Count alias [datafusion]

2025-02-27 Thread via GitHub
jayzhan211 commented on code in PR #14927: URL: https://github.com/apache/datafusion/pull/14927#discussion_r1974873043 ## datafusion/sqllogictest/test_files/subquery.slt: ## @@ -1393,3 +1393,37 @@ item1 1970-01-01T00:00:03 75 statement ok drop table source_table; + +# test c

Re: [PR] Count alias [datafusion]

2025-02-27 Thread via GitHub
jayzhan211 commented on code in PR #14927: URL: https://github.com/apache/datafusion/pull/14927#discussion_r1974843114 ## datafusion/core/tests/dataframe/mod.rs: ## @@ -2545,9 +2652,24 @@ async fn test_count_wildcard_on_where_exist() -> Result<()> { .collect()

Re: [PR] Count alias [datafusion]

2025-02-27 Thread via GitHub
jayzhan211 commented on code in PR #14927: URL: https://github.com/apache/datafusion/pull/14927#discussion_r1974841086 ## datafusion/core/tests/dataframe/mod.rs: ## @@ -2469,9 +2470,53 @@ async fn test_count_wildcard_on_sort() -> Result<()> { .explain(false, false)?

Re: [PR] Count alias [datafusion]

2025-02-27 Thread via GitHub
jayzhan211 commented on PR #14927: URL: https://github.com/apache/datafusion/pull/14927#issuecomment-2689800403 ```rust /// Return `self AS name` alias expression pub fn alias(self, name: impl Into) -> Expr { Expr::Alias(Alias::new(self, None::<&str>, name.into()))