jayzhan211 commented on code in PR #14927: URL: https://github.com/apache/datafusion/pull/14927#discussion_r1974841086
########## datafusion/core/tests/dataframe/mod.rs: ########## @@ -2469,9 +2470,53 @@ async fn test_count_wildcard_on_sort() -> Result<()> { .explain(false, false)? .collect() .await?; - //make sure sql plan same with df plan + + // TODO: Remove duplicated alias in Sort + let expected_sql_result = "+---------------+------------------------------------------------------------------------------------------------------------+\ + \n| plan_type | plan |\ + \n+---------------+------------------------------------------------------------------------------------------------------------+\ + \n| logical_plan | Projection: t1.b, count(*) |\ + \n| | Sort: count(Int64(1)) AS count(*) AS count(*) ASC NULLS LAST |\ Review Comment: #14895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org