alamb commented on PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#issuecomment-2637539228
> Thanks @comphead for your feedback. We appreciate it 🙏
>
> > What comes to my mind is the PR might make the output too cumbersome
>
> The actual error output doesn't chan
eliaperantoni commented on code in PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#discussion_r1943292631
##
datafusion/sqllogictest/src/engines/datafusion_engine/error.rs:
##
@@ -30,7 +30,7 @@ pub enum DFSqlLogicTestError {
#[error("SqlLogicTest error(from
alamb commented on code in PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#discussion_r1943247569
##
datafusion/sqllogictest/src/engines/datafusion_engine/error.rs:
##
@@ -30,7 +30,7 @@ pub enum DFSqlLogicTestError {
#[error("SqlLogicTest error(from sqllogic
eliaperantoni commented on PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#issuecomment-2635144203
Thanks @comphead for your feedback. We appreciate it 🙏
> What comes to my mind is the PR might make the output too cumbersome
The actual error output doesn't change
mkarbo commented on PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#issuecomment-2635090710
> Thanks @eliaperantoni
>
> What comes to my mind is the PR might make the output too cumbersome, and
some time back I think we already faced the issue that extra attention to
comphead commented on PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#issuecomment-2634819291
Thanks @eliaperantoni
What comes to my mind is the PR might make the output too cumbersome, and
some time back I think we already faced the issue that extra attention to error
c
eliaperantoni commented on code in PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#discussion_r1940882597
##
datafusion/sqllogictest/test_files/errors.slt:
##
@@ -129,26 +129,34 @@ order by c9
# nth_value with wrong name
-statement error DataFusion error: Er
eliaperantoni commented on code in PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#discussion_r1940880835
##
datafusion/sqllogictest/src/engines/datafusion_engine/error.rs:
##
@@ -30,7 +30,7 @@ pub enum DFSqlLogicTestError {
#[error("SqlLogicTest error(from
eliaperantoni commented on PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#issuecomment-2631306971
@alamb pr is ready for review. I'm getting this weird error that appears to
be because of the TTY size being smaller in CI, making the error wrap on a new
line? I can't reprodu
eliaperantoni opened a new pull request, #14439:
URL: https://github.com/apache/datafusion/pull/14439
This PR adds `DataFusionError::Collection` so that multiple errors can be
returned at once, shortening the feedback loop for developers because they
would now be able to fix more than error
10 matches
Mail list logo
