eliaperantoni commented on code in PR #14439:
URL: https://github.com/apache/datafusion/pull/14439#discussion_r1940880835
##########
datafusion/sqllogictest/src/engines/datafusion_engine/error.rs:
##########
@@ -30,7 +30,7 @@ pub enum DFSqlLogicTestError {
#[error("SqlLogicTest error(from sqllogictest-rs crate): {0}")]
SqlLogicTest(#[from] TestError),
/// Error from datafusion
- #[error("DataFusion error: {0}")]
+ #[error("DataFusion error: {}", .0.strip_backtrace())]
Review Comment:
Okay so it turns out that the issue was that the expected error doesn't
contain the backtrace but the actual one does. I couldn't reproduce locally at
first because I wasn't using the `backtrace` feature.
I have no idea why running with `--complete` didn't write the backtrace to
the `.slt` files, I find no call to `strip_backtrace` and I don't know what in
my PR made this necessary. But it works 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
