kazantsev-maksim closed pull request #1864: Chore: implement predicate exprs as
ScalarUDFImpl
URL: https://github.com/apache/datafusion-comet/pull/1864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
kazantsev-maksim commented on PR #1864:
URL:
https://github.com/apache/datafusion-comet/pull/1864#issuecomment-2997231061
> > Ci is failing because in (`iceberg_compat`)`initRecordBatchReader` we
call `planner.createExpr` for predicates that are pushed down and the
expressions are no longe
mbutrovich commented on PR #1864:
URL:
https://github.com/apache/datafusion-comet/pull/1864#issuecomment-2996336512
> Ci is failing because in (`iceberg_compat`)`initRecordBatchReader` we call
`planner.createExpr` for predicates that are pushed down and the expressions
are no longer there.
kazantsev-maksim commented on code in PR #1864:
URL: https://github.com/apache/datafusion-comet/pull/1864#discussion_r2160393687
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -952,32 +947,23 @@ object QueryPlanSerde extends Logging with CometExprShim
parthchandra commented on PR #1864:
URL:
https://github.com/apache/datafusion-comet/pull/1864#issuecomment-2971784129
Ci is failing because in (`iceberg_compat`)`initRecordBatchReader` we call
`planner.createExpr` for predicates that are pushed down and the expressions
are no longer there
andygrove commented on code in PR #1864:
URL: https://github.com/apache/datafusion-comet/pull/1864#discussion_r2143696076
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -952,32 +947,23 @@ object QueryPlanSerde extends Logging with CometExprShim {
andygrove commented on code in PR #1864:
URL: https://github.com/apache/datafusion-comet/pull/1864#discussion_r2143694940
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -952,32 +947,23 @@ object QueryPlanSerde extends Logging with CometExprShim {
codecov-commenter commented on PR #1864:
URL:
https://github.com/apache/datafusion-comet/pull/1864#issuecomment-2954088958
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1864?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
kazantsev-maksim opened a new pull request, #1864:
URL: https://github.com/apache/datafusion-comet/pull/1864
## Which issue does this PR close?
Part of https://github.com/apache/datafusion-comet/issues/1819
## Rationale for this change
See https://github.com/apache/datafu
