kazantsev-maksim commented on PR #1864: URL: https://github.com/apache/datafusion-comet/pull/1864#issuecomment-2997231061
> > Ci is failing because in (`iceberg_compat`)`initRecordBatchReader` we call `planner.createExpr` for predicates that are pushed down and the expressions are no longer there. @andygrove not sure how we should address this. > > I didn't realize that @kazantsev-maksim and I were independently looking at the same task: > > #1887 > > We do separate expression serialization in the Parquet reader, which would need to be brought into alignment as in #1887. The only issue I'm fighting on #1887 is that dictionary-encoded columns need to be unpacked first for the DF scalar function, which I am looking at fixing. I can close this PR and work on another task. Looks like @mbutrovich is almost finished. @andygrove -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
