Re: [PR] Change tpch validation to use `exec_sql_on_tables` [datafusion-ray]

2025-02-28 Thread via GitHub
andygrove merged PR #66: URL: https://github.com/apache/datafusion-ray/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafu

Re: [PR] Change tpch validation to use `exec_sql_on_tables` [datafusion-ray]

2025-02-28 Thread via GitHub
andygrove commented on code in PR #66: URL: https://github.com/apache/datafusion-ray/pull/66#discussion_r1975841145 ## src/util.rs: ## @@ -397,6 +402,52 @@ fn print_node(plan: &Arc, indent: usize, output: &mut String) } } +async fn exec_sql(query: String, tables: Vec<(S

Re: [PR] Change tpch validation to use `exec_sql_on_tables` [datafusion-ray]

2025-02-27 Thread via GitHub
vmingchen commented on code in PR #66: URL: https://github.com/apache/datafusion-ray/pull/66#discussion_r1973563759 ## src/util.rs: ## @@ -397,6 +402,52 @@ fn print_node(plan: &Arc, indent: usize, output: &mut String) } } +async fn exec_sql(query: String, tables: Vec<(S

Re: [PR] Change tpch validation to use `exec_sql_on_tables` [datafusion-ray]

2025-02-27 Thread via GitHub
vmingchen commented on code in PR #66: URL: https://github.com/apache/datafusion-ray/pull/66#discussion_r1973563759 ## src/util.rs: ## @@ -397,6 +402,52 @@ fn print_node(plan: &Arc, indent: usize, output: &mut String) } } +async fn exec_sql(query: String, tables: Vec<(S

Re: [PR] Change tpch validation to use `exec_sql_on_tables` [datafusion-ray]

2025-02-26 Thread via GitHub
andygrove commented on code in PR #66: URL: https://github.com/apache/datafusion-ray/pull/66#discussion_r1972273649 ## src/util.rs: ## @@ -397,6 +402,52 @@ fn print_node(plan: &Arc, indent: usize, output: &mut String) } } +async fn exec_sql(query: String, tables: Vec<(S

Re: [PR] Change tpch validation to use `exec_sql_on_tables` [datafusion-ray]

2025-02-26 Thread via GitHub
robtandy commented on PR #66: URL: https://github.com/apache/datafusion-ray/pull/66#issuecomment-2685277160 @vmingchen, thank you! This looks good to me! cc @andygrove for approval -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Change tpch validation to use `exec_sql_on_tables` [datafusion-ray]

2025-02-26 Thread via GitHub
vmingchen opened a new pull request, #66: URL: https://github.com/apache/datafusion-ray/pull/66 Fixes https://github.com/apache/datafusion-ray/issues/65 `exec_sql_on_tables` is a util function added by this PR that uses DataFution without Ray to execute queries. This ensures the valid