andygrove commented on code in PR #66:
URL: https://github.com/apache/datafusion-ray/pull/66#discussion_r1972273649


##########
src/util.rs:
##########
@@ -397,6 +402,52 @@ fn print_node(plan: &Arc<dyn ExecutionPlan>, indent: 
usize, output: &mut String)
     }
 }
 
+async fn exec_sql(query: String, tables: Vec<(String, String)>) -> 
PyResult<RecordBatch> {
+    let ctx = SessionContext::new();
+    for (name, path) in tables {
+        if path.ends_with(".parquet") {

Review Comment:
   It may be better to check if path is a file or directory rather than basing 
the logic on file extension.
   
   For example, in my local setup, I have a directory named `customer.parquet` 
that contains multiple Parquet files.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to