Re: [PR] Avoid treating incomparable scalars as equal [datafusion]

2025-07-01 Thread via GitHub
findepi merged PR #16624: URL: https://github.com/apache/datafusion/pull/16624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafu

Re: [PR] Avoid treating incomparable scalars as equal [datafusion]

2025-06-30 Thread via GitHub
findepi commented on code in PR #16624: URL: https://github.com/apache/datafusion/pull/16624#discussion_r2175762054 ## datafusion/common/src/scalar/mod.rs: ## @@ -3343,6 +3339,14 @@ impl ScalarValue { arr1 == &right } +/// Compare `self` with `other` and retu

Re: [PR] Avoid treating incomparable scalars as equal [datafusion]

2025-06-30 Thread via GitHub
alamb commented on code in PR #16624: URL: https://github.com/apache/datafusion/pull/16624#discussion_r2175729099 ## datafusion/common/src/scalar/mod.rs: ## @@ -3343,6 +3339,14 @@ impl ScalarValue { arr1 == &right } +/// Compare `self` with `other` and return

[PR] Avoid treating incomparable scalars as equal [datafusion]

2025-06-30 Thread via GitHub
findepi opened a new pull request, #16624: URL: https://github.com/apache/datafusion/pull/16624 Fix calls to `ScalarValue::partial_cmp` that treat `None` return value as equivalent to equality. The `partial_cmp` returns `None` when values cannot be compared, for example they have incompatib