findepi commented on code in PR #16624:
URL: https://github.com/apache/datafusion/pull/16624#discussion_r2175762054
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -3343,6 +3339,14 @@ impl ScalarValue {
arr1 == &right
}
+ /// Compare `self` with `other` and return an `Ordering`.
+ /// Returns `Err` if the values cannot be compared, e.g., they have
incompatible data types.
+ pub fn try_cmp(&self, other: &Self) -> Result<Ordering> {
+ self.partial_cmp(other).ok_or_else(|| {
+ _internal_datafusion_err!("Uncomparable values: {self:?},
{other:?}")
Review Comment:
i think it's internal in that sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
