github-actions[bot] closed pull request #12186: Adding node_id to
ExecutionPlanProperties
URL: https://github.com/apache/datafusion/pull/12186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
github-actions[bot] commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2664435616
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
berkaysynnada commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2554359314
Hi @emgeee and @ameyc. I apologize again for the delay in providing
feedback, but I believe we can iterate quickly now and align on the best design
to suit every use case.
berkaysynnada commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2551158629
Apologies for the delay in responding. I have started working on this issue
and will open a draft PR to facilitate discussion, FYI @emgeee. I plan to share
it today or tomorrow
ozankabak commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2523274089
Sorry, some other priorities kept me busy and this slipped through the
cracks. @berkaysynnada let's prioritize this for next week.
--
This is an automated message from the Apache
emgeee commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2517980709
Hey @ozankabak have you gotten a chance to revisit this yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
ozankabak commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2450040609
Going through our implementation I see that we were able to get around the
non-existing ID problem by using string IDs and an auto-generation logic for
non-leaf nodes.
I wil
ozankabak commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2444857269
It is on my agenda for this week. I have been traveling causing a delay on
this project (and some others).
I remain convinced some version of this functionality belongs to th
emgeee commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2442634289
@ozankabak have you had a chance to take a look at this yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
ozankabak commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2365052960
> @ozankabak would love any pointers. this code is admittedly a quick draft.
so we pass in a hashmap and recursivesly traverse the tree.
Thanks for the sketch, I see the chal
emgeee commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2350589254
Just chiming in -- the implementation in this PR seems quite reasonable to
me. While there are definitely ways to hack around the limitation of not having
Node IDs, those strategies w
ameyc commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2347328029
@ozankabak would love any pointers. this code is admittedly a quick draft.
so we pass in a hashmap and recursivesly traverse the tree.
```
pub struct NodeIdAnnotator {
ozankabak commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2344456059
> Taking a second look at implementing this the using a global hashmap with
pointers to Arc and solution is somewhat more hacky and error prone and as
developers trying to build on
ameyc commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2344426743
Taking a second look at implementing this the using a global hashmap with
pointers to Arc and solution is somewhat more hacky and error
prone and as developers trying to build on top o
ozankabak commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2326620705
Let's create a new example file, add the traversal logic and a simple of
demonstration of how to store the node <-> id association via a map in that
file. I think it will be a fair
ameyc commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2322523284
> I think it would be great to add the traversal code and the map approach I
mentioned as an example to upstream for future users who want to do something
like this. This is an approac
ozankabak commented on PR #12186:
URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2311761786
We had similar challenges when using DataFusion in a context similar to
yours (checkpointing etc.) I have consulted with my team on how we solved them,
and discussed this general a
ameyc opened a new pull request, #12186:
URL: https://github.com/apache/datafusion/pull/12186
## Which issue does this PR close?
Closes #11364
## Rationale for this change
Currently ExecutionPlans dont have an identifier associated with them,
making it hard to disti
18 matches
Mail list logo
