ozankabak commented on PR #12186: URL: https://github.com/apache/datafusion/pull/12186#issuecomment-2365052960
> @ozankabak would love any pointers. this code is admittedly a quick draft. so we pass in a hashmap and recursivesly traverse the tree. Thanks for the sketch, I see the challenge. After reviewing your sketch and going back to our solution in our fork, it seems to me like it may indeed make sense to add this functionality natively to upstream DF. That being said, I am worried about a few things (default value being `None`, placement of a non-derived attribute living in `PlanProperties` etc.), but I think we can find a design that mitigates my concerns. Next week, me (or maybe @berkaysynnada) will work on a draft PR to flesh out some ideas on our end, then we can compare/contrast and arrive at a final design together. Then we can get some extra community review and merge this if noone else has other concerns or objections (whether this functionality should belong to core etc.) Thanks for awesome collaboration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
