gabotechs commented on PR #16503:
URL: https://github.com/apache/datafusion/pull/16503#issuecomment-3022021502
> Duration doesn't really map 1:1 with IntervalDay. Duration has a single
logical component for time, but IntervalDay has two logical components, time
and days.
🤔 it still d
jkosh44 commented on PR #16503:
URL: https://github.com/apache/datafusion/pull/16503#issuecomment-3016010500
@gabotechs This response from Substrait makes me a little nervous about this
approach:
https://github.com/substrait-io/substrait/issues/822#issuecomment-3008350100
Duration do
alamb merged PR #16503:
URL: https://github.com/apache/datafusion/pull/16503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16503:
URL: https://github.com/apache/datafusion/pull/16503#issuecomment-3005915991
Thanks again @jkosh44 and @gabotechs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jkosh44 commented on PR #16503:
URL: https://github.com/apache/datafusion/pull/16503#issuecomment-3002105716
Just made the suggested updates.
I don't 100% know how the substrait plans are used, but I am slightly
worried about one thing with this approach. Would it be possible to cons
alamb commented on PR #16503:
URL: https://github.com/apache/datafusion/pull/16503#issuecomment-3004828625
> I don't 100% know how the substrait plans are used, but I am slightly
worried about one thing with this approach. Would it be possible to construct a
substrait plan that converts the
gabotechs commented on code in PR #16503:
URL: https://github.com/apache/datafusion/pull/16503#discussion_r2164581001
##
datafusion/substrait/src/variation_const.rs:
##
@@ -55,6 +55,8 @@ pub const LARGE_CONTAINER_TYPE_VARIATION_REF: u32 = 1;
pub const VIEW_CONTAINER_TYPE_VARIAT
gabotechs commented on PR #16503:
URL: https://github.com/apache/datafusion/pull/16503#issuecomment-2998046913
Sure! I'll get it done in a couple of days. Thanks for submitting this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
alamb commented on PR #16503:
URL: https://github.com/apache/datafusion/pull/16503#issuecomment-2997820357
Thank you @jkosh44 🙏
@gabotechs is there any chance you have time to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message,
jkosh44 opened a new pull request, #16503:
URL: https://github.com/apache/datafusion/pull/16503
## Which issue does this PR close?
- Closes #16285.
## Rationale for this change
This commit adds support for Arrow Duration types in Substrait plans.
Substrait has no equival
10 matches
Mail list logo
