gabotechs commented on code in PR #16503: URL: https://github.com/apache/datafusion/pull/16503#discussion_r2164581001
########## datafusion/substrait/src/variation_const.rs: ########## @@ -55,6 +55,8 @@ pub const LARGE_CONTAINER_TYPE_VARIATION_REF: u32 = 1; pub const VIEW_CONTAINER_TYPE_VARIATION_REF: u32 = 2; pub const DECIMAL_128_TYPE_VARIATION_REF: u32 = 0; pub const DECIMAL_256_TYPE_VARIATION_REF: u32 = 1; +pub const DEFAULT_INTERVAL_DAY_TYPE_VARIATION: u32 = 0; +pub const DURATION_INTERVAL_DAY_TYPE_VARIATION: u32 = 1; Review Comment: Nice idea using the type variation capabilities, this looks good to me 👍. Nit 1: maybe prefixing this constants with `_REF` as all the others? Nit 2: maybe adding a comment explaining that the default variation maps to `DataType::Interval(DayTime)` and the other maps to `DataType::Duration`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
