github-actions[bot] closed pull request #13888: Add substrait tpch round trip
tests from sql query
URL: https://github.com/apache/datafusion/pull/13888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
github-actions[bot] commented on PR #13888:
URL: https://github.com/apache/datafusion/pull/13888#issuecomment-2731392253
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
alamb commented on PR #13888:
URL: https://github.com/apache/datafusion/pull/13888#issuecomment-2596828631
I am trying to clear out the review queue (make it clearer what PRs are
waiting on review and what are not).
Marking as draft as I think this PR is no longer waiting on feedback. Pl
alamb commented on PR #13888:
URL: https://github.com/apache/datafusion/pull/13888#issuecomment-2561185596
(I really like the idea of merging the tests, even if they don't all pass,
in one PR and then working on fixes to the tests as additional follow on PRs)
--
This is an automated messa
alamb commented on PR #13888:
URL: https://github.com/apache/datafusion/pull/13888#issuecomment-2561185054
> Lastly, is it convention that we would add #[ignore] to the cases that do
not pass at the moment, and open those up as we fix bugs?
I think that is a reasonable approach -- tha
robtandy commented on PR #13888:
URL: https://github.com/apache/datafusion/pull/13888#issuecomment-2560251488
Thank you @vbarua and @Blizzara for your review and comments!
Yes, I think the existing tests do not go far enough, and I encountered bugs
not covered by these tests already,
Blizzara commented on PR #13888:
URL: https://github.com/apache/datafusion/pull/13888#issuecomment-2560223118
Haha, looks like @vbarua commented pretty pretty much the same thing while I
was writing my own reply! 😄
--
This is an automated message from the Apache Git Service.
To respond t
Blizzara commented on PR #13888:
URL: https://github.com/apache/datafusion/pull/13888#issuecomment-2560214683
I like the idea, more testing the better! We already have some Substrait TCP
testing, but I think that's from "known Substrait" -> DF, so it only tests the
consumer, while this woul
vbarua commented on code in PR #13888:
URL: https://github.com/apache/datafusion/pull/13888#discussion_r1896067593
##
datafusion/substrait/tests/testdata/tpch_queries/query_01.sql:
##
@@ -0,0 +1,22 @@
+SELECT
+l_returnflag,
+l_linestatus,
+sum(l_quantity) AS sum_qty,
vbarua commented on PR #13888:
URL: https://github.com/apache/datafusion/pull/13888#issuecomment-2560209539
There are already some tests for TPCH functionality in
https://github.com/apache/datafusion/blob/main/datafusion/substrait/tests/cases/consumer_integration.rs,
but IMO those are weake
vbarua commented on code in PR #13888:
URL: https://github.com/apache/datafusion/pull/13888#discussion_r1896058000
##
datafusion/substrait/tests/testdata/tpch_queries/query_01.sql:
##
@@ -0,0 +1,22 @@
+SELECT
+l_returnflag,
+l_linestatus,
+sum(l_quantity) AS sum_qty,
robtandy opened a new pull request, #13888:
URL: https://github.com/apache/datafusion/pull/13888
## Which issue does this PR close?
I've been investigating and experimenting with federating tpch query plans
and sending the federated portion downstream encoded as substrait protos (Side
12 matches
Mail list logo
