robtandy commented on PR #13888: URL: https://github.com/apache/datafusion/pull/13888#issuecomment-2560251488
Thank you @vbarua and @Blizzara for your review and comments! Yes, I think the existing tests do not go far enough, and I encountered bugs not covered by these tests already, which is why i wrote these. I did not notice the existing schemas and sql in the benchmarks crate. I'll look to reuse them. Should we move them somewhere so that bench and test can access them without referring to each other? Lastly, is it convention that we would add `#[ignore]` to the cases that do not pass at the moment, and open those up as we fix bugs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
