comphead merged PR #16389:
URL: https://github.com/apache/datafusion/pull/16389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
simonvandel commented on code in PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#discussion_r2145802029
##
datafusion/sql/src/select.rs:
##
@@ -374,6 +383,14 @@ impl SqlToRel<'_, S> {
fn try_process_aggregate_unnest(&self, input: LogicalPlan) ->
Result {
alamb commented on code in PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#discussion_r2145582029
##
datafusion/sql/src/select.rs:
##
@@ -374,6 +383,14 @@ impl SqlToRel<'_, S> {
fn try_process_aggregate_unnest(&self, input: LogicalPlan) ->
Result {
alamb commented on PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#issuecomment-2971026040
> logical_select_all_from_1000 10.80 120.4±0.22ms
? ?/sec1.00 11.1±0.06ms? ?/sec
🚀
The other planning benchmarks look like prett
alamb commented on PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#issuecomment-2970575208
🤖: Benchmark completed
Details
```
group main
opt-process-unnest
-
alamb commented on PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#issuecomment-2970396033
🤖 `./gh_compare_branch_bench.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch_bench.sh)
Running
Linux aal-dev 6.11.0-1015-gcp #15~
jonathanc-n commented on code in PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#discussion_r2144397352
##
datafusion/sql/src/select.rs:
##
@@ -374,6 +383,14 @@ impl SqlToRel<'_, S> {
fn try_process_aggregate_unnest(&self, input: LogicalPlan) ->
Result {
simonvandel opened a new pull request, #16389:
URL: https://github.com/apache/datafusion/pull/16389
## Which issue does this PR close?
- Closes https://github.com/apache/datafusion/issues/16242
## Rationale for this change
Reduce planning work for unnest e
