Shreyaskr1409 commented on PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#issuecomment-2767283404
@berkaysynnada thank you, actually I did use the datafusion-examples as
reference.
> Perhaps we can make this in datafusion-examples as well
Yeah that could also b
Shreyaskr1409 commented on code in PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#discussion_r2021131776
##
datafusion/physical-expr/src/aggregate.rs:
##
@@ -97,6 +97,167 @@ impl AggregateExprBuilder {
/// Constructs an `AggregateFunctionExpr` from the buil
alamb merged PR #15504:
URL: https://github.com/apache/datafusion/pull/15504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
Shreyaskr1409 commented on PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#issuecomment-2771640045
@alamb thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
alamb commented on PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#issuecomment-2770660147
I also merged up from main to fix the CO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on code in PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#discussion_r2023660049
##
datafusion/physical-expr/src/aggregate.rs:
##
@@ -97,6 +97,165 @@ impl AggregateExprBuilder {
/// Constructs an `AggregateFunctionExpr` from the builder
Shreyaskr1409 commented on PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#issuecomment-2769978312
@alamb Thank you so much, I have resolved all the conversations. Everything
is working and tested, and even I got to learn new stuff from this.
--
This is an automated messag
alamb commented on code in PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#discussion_r2023192876
##
datafusion/physical-expr/src/aggregate.rs:
##
@@ -97,6 +97,167 @@ impl AggregateExprBuilder {
/// Constructs an `AggregateFunctionExpr` from the builder
Shreyaskr1409 commented on code in PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#discussion_r2023166785
##
datafusion/physical-expr/src/aggregate.rs:
##
@@ -97,6 +97,167 @@ impl AggregateExprBuilder {
/// Constructs an `AggregateFunctionExpr` from the buil
alamb commented on code in PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#discussion_r2023080660
##
datafusion/physical-expr/src/aggregate.rs:
##
@@ -97,6 +97,167 @@ impl AggregateExprBuilder {
/// Constructs an `AggregateFunctionExpr` from the builder
alamb commented on PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#issuecomment-2769364593
> @berkaysynnada thank you, actually I did use the datafusion-examples as
reference.
>
> > Perhaps we can make this in datafusion-examples as well
>
> Yeah that could also
berkaysynnada commented on PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#issuecomment-2767270135
Very nice example, thank you @Shreyaskr1409. Perhaps we can make this in
datafusion-examples as well?
--
This is an automated message from the Apache Git Service.
To respond
Shreyaskr1409 commented on PR #15504:
URL: https://github.com/apache/datafusion/pull/15504#issuecomment-2766368569
The problems I am facing are:
1. i can not use datafusion crate inside the examples. i could not test the
portion where I am building from AggregateExprBuilder.
